Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Enhance debug, trace & info logs for remote store flows (#10182) #10237

Merged
merged 2 commits into from
Sep 27, 2023
Merged

[Backport 2.x] Enhance debug, trace & info logs for remote store flows (#10182) #10237

merged 2 commits into from
Sep 27, 2023

Conversation

ashking94
Copy link
Member

Backports e617da3 from #10182

@ashking94 ashking94 mentioned this pull request Sep 26, 2023
Merged
6 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2023 •
edited
Loading

Compatibility status:

Checks if related components are compatible with change bde1dff

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@ashking94
Enhance debug, trace & info logs for remote store flows (opensearch-p…
8bc4f8a 
…roject#10182)

* Enhance debug, trace & info logs for remote store flows

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Add shardId to logger and more logs

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Rename unkwown index name to _unknown_

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Empty-Commit

Signed-off-by: Ashish Singh <ssashish@amazon.com>

---------

Signed-off-by: Ashish Singh <ssashish@amazon.com>
@ashking94
Empty-Commit
bde1dff 
Signed-off-by: Ashish Singh <ssashish@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testDeleteOperations

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #10237 (bde1dff) into 2.x (ecb3ed5) will increase coverage by 0.00%.
Report is 3 commits behind head on 2.x.
The diff coverage is 86.27%.

@@            Coverage Diff             @@
##                2.x   #10237    +/-   ##
==========================================
  Coverage     70.74%   70.75%            
+ Complexity    58276    58261    -15     
==========================================
  Files          4814     4814            
  Lines        275430   275523    +93     
  Branches      40493    40501     +8     
==========================================
+ Hits         194853   194940    +87     
+ Misses        63973    63878    -95     
- Partials      16604    16705   +101
Files Coverage Δ
...src/main/java/org/opensearch/core/index/Index.java 100.00% <ø> (ø)
...c/main/java/org/opensearch/index/IndexService.java 75.59% <100.00%> (ø)
...rch/index/remote/RemoteSegmentTransferTracker.java 81.10% <100.00%> (+0.17%) ⬆️
...index/shard/CloseableRetryableRefreshListener.java 81.03% <100.00%> (+0.67%) ⬆️
...java/org/opensearch/index/shard/StoreRecovery.java 56.95% <ø> (+0.67%) ⬆️
...earch/index/store/RemoteSegmentStoreDirectory.java 89.67% <100.00%> (-0.40%) ⬇️
...ndex/store/RemoteSegmentStoreDirectoryFactory.java 92.30% <100.00%> (ø)
...rc/main/java/org/opensearch/index/store/Store.java 81.71% <100.00%> (+0.33%) ⬆️
...search/index/translog/InternalTranslogManager.java 66.66% <100.00%> (-4.67%) ⬇️
...rg/opensearch/index/translog/RemoteFsTranslog.java 70.53% <100.00%> (-0.41%) ⬇️
... and 12 more

... and 458 files with indirect coverage changes

@sachinpkale sachinpkale merged commit 6e4a11e into opensearch-project:2.x Sep 27, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sachinpkale sachinpkale sachinpkale approved these changes

@reta reta Awaiting requested review from reta reta is a code owner

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@setiah setiah Awaiting requested review from setiah

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@peternied peternied Awaiting requested review from peternied

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

Assignees
No one assigned
Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashking94 @sachinpkale